Test tpm function and bug fix #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please post a comment once this is passing CI and ready for review. |
leonjia0112
force-pushed
the
branch3
branch
3 times, most recently
from
0add463 to
952439a
Compare
|
Comment out the tpm execution test cases to pass CI. Not it is ready for a review. Thanks. |
frozencemetery
suggested changes
Nov 8, 2018
leonjia0112
force-pushed
the
branch3
branch
2 times, most recently
from
da2a57a to
f96e491
Compare
|
Removed unnecessary changes on README.md file and test.json file. |
frozencemetery
suggested changes
Nov 8, 2018
1. Add test cases to test tpm command execution conditional, those test will execute tpm test if tpm is availablem, otherwise, pass as default. 2. Fix bug in run() functions to allow it execute tpm command.i 3. Add comment for each function for clear explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few test case to make sure the tpm function is working. Skipped quote function test, because I haven't figured out how to test this function. Also added some comments for each function to make clear what it does. Fixed some bug in tmp functions, now it is able to execute tpm command and getting the result back from tpm.
But it won't pass the CI since CI doesn't contain tpm with it.