-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actix_web Implementation #135
Conversation
info!("Listening on http://{}", addr); | ||
|
||
server.await?; | ||
let actix_server = HttpServer::new(move || { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mounting of routes and the creation of the server directly seems like it would make sense in another file and used here. However I think this is good as is and can be changed later if we decide to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a play with that , something like routes.rs
, it may be tricky though because of actix being heavily future based. I had a good look on github searches , but not many folks were separating the routes out of main. I do agree though, its a cleaner way of doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- though I'd recommend squashing the commits down before merge.
Same error I was seeing. Looks like a version mismatch. |
@puiterwijk I am not sure if I am recalling correctly, but you thought you had a fix for this? |
Implement actix web and handlers required for the keylime agent.
The routes are mostly placeholders for now.