Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix_web Implementation #135

Merged
merged 3 commits into from
Oct 26, 2020
Merged

actix_web Implementation #135

merged 3 commits into from
Oct 26, 2020

Conversation

lukehinds
Copy link
Member

Implement actix web and handlers required for the keylime agent.

The routes are mostly placeholders for now.

info!("Listening on http://{}", addr);

server.await?;
let actix_server = HttpServer::new(move || {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mounting of routes and the creation of the server directly seems like it would make sense in another file and used here. However I think this is good as is and can be changed later if we decide to do so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a play with that , something like routes.rs , it may be tricky though because of actix being heavily future based. I had a good look on github searches , but not many folks were separating the routes out of main. I do agree though, its a cleaner way of doing it.

Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- though I'd recommend squashing the commits down before merge.

@ashcrow
Copy link
Contributor

ashcrow commented Oct 21, 2020

  thread 'main' panicked at 'Error with pkg-config finding tss2-esys.: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"tss2-esys\" \"tss2-esys >= 2.3.3\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Requested \'tss2-esys >= 2.3.3\' but version of tss2-esys is 2.3.2\nYou may find new versions of tss2-esys at https://github.com/tpm2-software/tpm2-tss\n" } }', /home/runner/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/tss-esapi-4.0.9-alpha.1/build.rs:14:14

Same error I was seeing. Looks like a version mismatch.

@lukehinds
Copy link
Member Author

  thread 'main' panicked at 'Error with pkg-config finding tss2-esys.: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"tss2-esys\" \"tss2-esys >= 2.3.3\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Requested \'tss2-esys >= 2.3.3\' but version of tss2-esys is 2.3.2\nYou may find new versions of tss2-esys at https://github.com/tpm2-software/tpm2-tss\n" } }', /home/runner/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/tss-esapi-4.0.9-alpha.1/build.rs:14:14

Same error I was seeing. Looks like a version mismatch.

@puiterwijk I am not sure if I am recalling correctly, but you thought you had a fix for this?

@lukehinds lukehinds merged commit a2386fa into keylime:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants