Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a Fedora container for CI #140

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Move to a Fedora container for CI #140

merged 1 commit into from
Nov 5, 2020

Conversation

puiterwijk
Copy link
Member

Signed-off-by: Patrick Uiterwijk [email protected]

@puiterwijk puiterwijk force-pushed the fixci branch 3 times, most recently from d80ec37 to b102f8e Compare November 5, 2020 14:15
@puiterwijk puiterwijk marked this pull request as draft November 5, 2020 14:16
@puiterwijk
Copy link
Member Author

At this moment, some cargo clippy checks are disabled because those require a bunch of code cleanup. After this PR gets merged, I'll work on that.

@puiterwijk
Move to a Fedora container for CI
fa599b6 
Signed-off-by: Patrick Uiterwijk <[email protected]>
@puiterwijk puiterwijk marked this pull request as ready for review November 5, 2020 14:25
@puiterwijk puiterwijk requested a review from lukehinds November 5, 2020 14:39
lukehinds
lukehinds approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks Patrick!

@puiterwijk puiterwijk merged commit 2added7 into keylime:master Nov 5, 2020
@puiterwijk puiterwijk deleted the fixci branch November 5, 2020 14:52
@lkatalin lkatalin mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puiterwijk @lukehinds