-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create_ek() to tpm.rs #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks decent with just one small comment!
src/tpm.rs
Outdated
let alg = match alg { | ||
Some(a) => a, | ||
None => { | ||
// TODO: What other values could be in keylime.conf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only other value we should consider correct is ecc
.
I'd say that the _ =>
should return an error instead.
8f5023c
to
9fd1faf
Compare
Here is an updated PR with an error for encryption algorithms other than rsa and ecc, and retrieving the TPM pub object and turning it into a I don't think that turning the TPM pub object into a |
5e864b4
to
a090d7d
Compare
Signed-off-by: Lily Sturmann <[email protected]>
If this needs more functionality, different return types, etc., please let me know.