Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secure mount function #15

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Add secure mount function #15

merged 1 commit into from
Nov 29, 2018

Conversation

leonjia0112
Copy link
Contributor

  1. contains unsafe libc function

@leonjia0112
Copy link
Contributor Author

Added secure mount function in a separated secure mount file. Test passed, ready for a review.

frozencemetery
frozencemetery suggested changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking at the python implementation, I have no idea what this code is for or why we want to mount a tmpfs. A good commit messages says why.

src/crypto.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
@leonjia0112 leonjia0112 force-pushed the branch5 branch 2 times, most recently from 5ff8f1f to 0efd5cf Compare November 16, 2018 22:09
@leonjia0112
Copy link
Contributor Author

Test passed, ready for a review. Thanks.

frozencemetery
frozencemetery suggested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per earlier review, I still have no idea what this change is for / why we're doing it.

src/common.rs Show resolved Hide resolved
@leonjia0112 leonjia0112 force-pushed the branch5 branch 2 times, most recently from 834d117 to 2aecc96 Compare November 20, 2018 21:21
@leonjia0112
Copy link
Contributor Author

Changed based on the request. Test passed, and ready for another review. Thanks.

I changed the commit message and added some inline comments for the code. Hope these could make it clearer about what the change is used for.

frozencemetery
frozencemetery suggested changes Nov 20, 2018
View reviewed changes
src/common.rs Outdated Show resolved Hide resolved
@leonjia0112 leonjia0112 force-pushed the branch5 branch 2 times, most recently from b1ed54b to c2b83a3 Compare November 21, 2018 15:04
@leonjia0112
Copy link
Contributor Author

leonjia0112 commented Nov 21, 2018 •
edited
Loading

Implemented requested changes. Test passed. Ready for a review. Thanks.

@frozencemetery frozencemetery merged commit 6da1c06 into keylime:master Nov 29, 2018
@frozencemetery
Copy link
Contributor

Change merged. Please take a look at the rewritten commit message.

@leonjia0112 leonjia0112 deleted the branch5 branch March 13, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonjia0112 @frozencemetery