-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt repo into "copy-labels-linked" automation action #150
Conversation
I think those enhancements both sound good; what do others think? |
I agree @lkatalin. They sound good to me too. |
Also, is there a way to make it opt-in vs opt-out? I don't like the idea of the upstream tool doing things to our repo we haven't explicitly enabled |
That is a valid case (for # 1), could we use some sort of 'hold' string that can be used to park a patch. You can see this in action on the coreos repo (by our own @ashcrow even) coreos/coreos-assembler#1790 (comment) If searching for strings is a headache, perhaps a label 'no-auto-commit' |
I like these ideas and if Mark's bot implemented them then I'd definitely be ok with this feature. |
I'm find with merging this PR as-is and if we want to add to the auto-merge stuff with the new features that could be a separate PR if everyone is in agreement. |
@mpeters @lukehinds Comment actions are definitely something I want to do, but it's a longer-term goal than this PR. Nothing preventing a patch from being filed whenever it is developed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pull-request-responsibility
, the repo providingrust-keylime
with its PR review cycle automation, is getting some new features!Auto-merge -- if all required merge criteria is met (ex. approval from x reviewers with write access, tests passing, no conflicts), PRs will automatically be merged
Copy linked labels -- if you link a PR to an issue, automatically copy any labels on the issue over to the PR. For example, if issue Bug: CI Build Failure #123 has the label "enhancement" and PR Bug: Error handling needed for config #124 is linked to Bug: CI Build Failure #123 (by using "Resolves #xyz"), PR Bug: Error handling needed for config #124 will automatically be tagged as "enhancement" as well
These new actions will be enabled by default soon. However, if one or both of these aren't appropriate forrust-keylime
, this patch will opt the repo out of both. Feel free to close if both sound good or merge if there are concerns with the above actions (or request changes if you only want to allow one).I've changed the automation action's behavior from opt-out to opt-in. This PR now opts
rust-keylime
into the newcopy-labels-linked
action as well as existing actions, while not enabling auto-merge (per @mpeters' concerns).