Implement get_ek() function #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puiterwijk
reviewed
Dec 10, 2020
src/tpm.rs
Outdated
|
|
||
| pub(crate) fn get_ek() -> Result<KeyHandle> { | ||
| let cfg_handle = | ||
| config_get("/etc/keylime.conf", "cloud_agent", "ek_handle")?; |
There was a problem hiding this comment.
Perhaps have the function take an &str of the config value, and use that? Basically, I think it would be nice if this just did the parsing into a KeyHandle, and let the config handling over to the main functions.
There was a problem hiding this comment.
@puiterwijk Let me know if this shorter version is more like what you're talking about here. I can revise if not.
puiterwijk
approved these changes
Dec 10, 2020
|
Actually, it might be useful to get a test added. But the code looks good to me. |
lkatalin
force-pushed
the
useek
branch
4 times, most recently
from
16f1f95 to
b5a563b
Compare
|
@puiterwijk I added some tests. I didn't see a way to get a value back out of a |
Signed-off-by: Lily Sturmann <[email protected]>
Signed-off-by: Lily Sturmann <[email protected]>
puiterwijk
approved these changes
Dec 18, 2020
|
Looks good to me! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115
I changed the name
to.get_ek()because that seems like what it does (rather than "use" the ek)Please let me know if I should make changes or if this isn't the right way to generate the key handle.