Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache license header to source files #163

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Apache license header to source files #163

merged 2 commits into from
Mar 4, 2021

Conversation

ashcrow
Copy link
Contributor

@ashcrow ashcrow commented Mar 3, 2021 •
edited
Loading

  • Add ASLv2 SPDX header to source files
  • Add license-header.tpl
  • Add commented out config for rustfmt to check for license headers in the future

Resolves #111

ashcrow added 2 commits March 3, 2021 11:26
@ashcrow
Add license header to source files
fdea6b4 
Closes keylime#111

Signed-off-by: Steve Milner <[email protected]>
@ashcrow
Add license header template
436966a 
rustfmt config is also updated for when license_template_path
is supported in stable.

Signed-off-by: Steve Milner <[email protected]>
@ashcrow ashcrow requested a review from lkatalin March 3, 2021 17:12
@ashcrow ashcrow changed the title Apache license header Apache license header to source files Mar 3, 2021
@ashcrow ashcrow mentioned this pull request Mar 3, 2021
Closed
@ashcrow
Copy link
Contributor Author

ashcrow commented Mar 3, 2021

@lkatalin I'm happy to wait on #158 to merge and rebase this on top if that would be helpful.

@lkatalin
Copy link
Contributor

lkatalin commented Mar 3, 2021

@lkatalin I'm happy to wait on #158 to merge and rebase this on top if that would be helpful.

Thanks! I'm not sure how much more review that one will need, so I am okay with this merging first. Then I can update headers in my PR.

@lkatalin
Copy link
Contributor

lkatalin commented Mar 3, 2021 •
edited
Loading

This looks good. Having the license_template_path in rustfmt.toml in the future will make it so that cargo fmt --all -- --check` will catch any files that don't have the header, is that right?

@ashcrow
Copy link
Contributor Author

ashcrow commented Mar 3, 2021

That's correct!

@ashcrow
Copy link
Contributor Author

ashcrow commented Mar 4, 2021

2 ✔️'s ... merging.

@ashcrow ashcrow merged commit a527818 into keylime:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkatalin lkatalin lkatalin approved these changes

@lukehinds lukehinds lukehinds approved these changes

@puiterwijk puiterwijk Awaiting requested review from puiterwijk

Assignees

@puiterwijk puiterwijk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apache 2.0 licensing headers needed
4 participants
@ashcrow @lkatalin @lukehinds @puiterwijk