Small fixes relating to Keylime components working together #165
Conversation
lkatalin
changed the title
|
@ashcrow I think I'd actually like to merge it and add more in a bit. It would help with keeping track of branches while I test some things. |
src/secure_mount.rs
Outdated
| Error::SecureMount( | ||
| format!( | ||
| "unable to change secure path dir owner to root: received exit code {}", | ||
| e.code().unwrap().unwrap() //#[allow_ci] |
There was a problem hiding this comment.
Generally we want to avoid unwrap but there may be cases where it's fine. It may be worth noting in a comment why it's in use in these cases.
There was a problem hiding this comment.
Completely agree. I don't think it can be avoided here, as they are Option types (but if you know a way, let me know). I added comments as suggested.
lkatalin
force-pushed
the
smallfixes
branch
2 times, most recently
from
42982bf to
75b516f
Compare
|
@ashcrow Sorry to push a new version after you approved! I took your point about the |
Signed-off-by: Lily Sturmann <[email protected]>
lkatalin
force-pushed
the
smallfixes
branch
3 times, most recently
from
aa32e03 to
5931d28
Compare
Signed-off-by: Lily Sturmann <[email protected]>
Signed-off-by: Lily Sturmann <[email protected]>
Signed-off-by: Lily Sturmann <[email protected]>
|
Merging this, as it had gotten two approvals, passed CI, and the update I pushed was just a comment. |
These all relate to running the
keylime_agent,keylime-verifier, andkeylime-registrarwithdocker-compose, but some of the fixes are also generally applicable. Backstory: I am trying to make sure the components can work together before writing the 3-party key protocol. These are changes I made while fixing some bugs or trying to understand them.I am still debugging some errors, so there are probably a few more commits to be added. EDIT: But these could go in an immediate future PR as well.Currently:
ERROR keylime_agent::revocation > Path for the 0mq socket: /tmp/secure/unzipped/RevocationNotifier-cert.crt doesn't exist