Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix communication errors between agent and registrar #166

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Fix communication errors between agent and registrar #166

merged 3 commits into from
Mar 15, 2021
+124 −27

Conversation

lkatalin
Copy link
Contributor

@lkatalin lkatalin commented Mar 9, 2021 •
edited
Loading

In this PR:

  • Update to send IPs and ports and env vars (resort to keylime.conf if vars are not present)
  • Add efivar-devel to keylime_py dockerfile
  • Add network_mode: host to keylime_agent in docker-compose file, update port bindings, use IP 0.0.0.0

Fixes #167

@lkatalin lkatalin force-pushed the icc branch 2 times, most recently from 0032948 to 81694cd Compare March 12, 2021 00:51
@lkatalin lkatalin changed the title Use static IPs in docker-compose and pass IPs as env vars Option to pass IPs as env vars Mar 12, 2021
@lkatalin lkatalin changed the title Option to pass IPs as env vars Fix communication errors between agent and registrar Mar 12, 2021
@lkatalin lkatalin force-pushed the icc branch 3 times, most recently from 09f6ac9 to 9151ce3 Compare March 12, 2021 22:14
@lkatalin lkatalin marked this pull request as ready for review March 12, 2021 22:39
@lkatalin lkatalin merged commit f767269 into keylime:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@puiterwijk puiterwijk Awaiting requested review from puiterwijk

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees

@puiterwijk puiterwijk

@lukehinds lukehinds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent and registrar not able to communicate when run via docker-compose
4 participants
@lkatalin @ashcrow @puiterwijk @lukehinds