Fix secure mount error and add more verbose TPM error output #171
Conversation
lkatalin
changed the title
lkatalin
force-pushed
the
tmpfs
branch
2 times, most recently
from
1316cf4 to
dade08a
Compare
| @@ -23,7 +23,7 @@ pub static KEY: &str = "secret"; | |||
| pub static WORK_DIR: &str = "/tmp"; | |||
|
|
|||
| // Secure mount of tpmfs (False is generally used for development environments) | |||
| pub static MOUNT_SECURE: bool = true; | |||
| pub static MOUNT_SECURE: bool = false; | |||
There was a problem hiding this comment.
Is the comment above still accurate? Would we be defaulting to a development configuration?
There was a problem hiding this comment.
Yeah, I'm not sure - my somewhat narrow goal has been to get the code into a state that it can run with docker-compose up without encountering any errors. In theory this would eventually be an integration test or example that someone who clones the repo could just run in a snap to make sure things are working and see how it should behave. Is there a better way to do this? Maybe a development "feature" in Cargo.toml?
There was a problem hiding this comment.
@lukehinds do you happen to know the result in changing this from true to false?
There was a problem hiding this comment.
I believe it results in the mount being in /tmp rather than a tmpfs mount. I figure if it helps Lily get moving for now we can we could keep it that way, but we should mark a todo or an issue. The other option is a config value to make it togglable outside of the code.
There was a problem hiding this comment.
I've changed this so that the flag is updated based on a feature we can pass in: cargo build --features=testing.
lkatalin
force-pushed
the
tmpfs
branch
2 times, most recently
from
63846c5 to
9ffd29c
Compare
Signed-off-by: Lily Sturmann <[email protected]>
This causes an intermittent error because it is not compatible with network_mode: host Signed-off-by: Lily Sturmann <[email protected]>
Configs for testing can be turned on by using `cargo <cmd> --features=testing` Signed-off-by: Lily Sturmann <[email protected]>
This PR: