Fix uppercase acronyms and use thiserror From derives #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2021
Merged
This fixes the error enum cases to no longer use uppercase acronyms. Signed-off-by: Patrick Uiterwijk <[email protected]>
The thiserror crate has a feature where it can automatically derive the From traits for error types by marking the cases. Use this code, to minimize on hand-written code. Signed-off-by: Patrick Uiterwijk <[email protected]>
puiterwijk
force-pushed
the
uppercase-fix
branch
from
6481975 to
9153eab
Compare
lkatalin
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.