Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for Identity and Integrity quotes #196

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

lkatalin
Copy link
Contributor

@lkatalin lkatalin commented Jun 7, 2021

This should pass CI when rebased on #195

Thoughts: the JsonWrapper and KeylimeQuote variations are completely based on the Python interface, so they could possibly go in their own interface module. On the other hand, there isn't much code here so it may not be necessary to separate it that way. Opinions welcome.

Also: will we ever need to use the vmask? From what I understand, it is only necessary when tying a vtpm value to a hardware tpm value, which isn't used anymore in the Python codebase? But I could be wrong here.

@lkatalin
Copy link
Contributor Author

@lukehinds @ashcrow @puiterwijk This is the next one when you get a chance : )

Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks familiar. Was this pulled out of an earlier PR?

@lkatalin
Copy link
Contributor Author

The code looks familiar. Was this pulled out of an earlier PR?

Yes, it was. I had a longer PR earlier that I broke down into smaller self-contained pieces to make them easier to review and also make them easier to iterate on as I debug. Thanks for looking at it @ashcrow !

@lkatalin lkatalin merged commit 7fbce21 into keylime:master Jun 23, 2021
@lkatalin lkatalin deleted the quotehandler branch July 16, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants