Do not fail if EK cert is not present in TPM NV #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @puiterwijk |
ueno
force-pushed
the
wip/dueno/ekcert
branch
2 times, most recently
from
3014b52 to
ce5bd73
Compare
puiterwijk
approved these changes
Jul 9, 2021
| @@ -40,11 +53,8 @@ fn is_empty(buf: &[u8]) -> bool { | |||
|
|
|||
| #[derive(Debug, Serialize, Deserialize)] | |||
| struct Register<'a> { | |||
| #[serde( | |||
| serialize_with = "serialize_as_base64", | |||
| skip_serializing_if = "is_empty" | |||
There was a problem hiding this comment.
Hah, right. I thought I had made the code check whether ekcert is in the json, but instead I made it assume that that's there and just check if that's json null.
Thanks for finding and fixing that!
|
@ueno could you rebase it? Then me or anyone else with write access can merge this! |
|
Thank you for the review; rebased. |
According to the spec (4.5.2), it is not mandatory that an EK certificate is pre-provisioned in NVRAM; actually some TPM chips do not have it, e.g., AMD fTPM, and the Python registrar tolerates "ekcert: null". Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec (4.5.2), it is not mandatory that an EK
certificate is pre-provisioned in NVRAM; actually some TPM chips do
not have it, e.g., AMD fTPM, and the Python registrar tolerates
"ekcert: null".
Signed-off-by: Daiki Ueno [email protected]