Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging example and some readme fix ups #24

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Add logging example and some readme fix ups #24

merged 1 commit into from
Dec 7, 2018

Conversation

lukehinds
Copy link
Member

Just getting my feet wet, so some typo fixes and a logging env example.

@leonjia0112
Copy link
Contributor

leonjia0112 commented Dec 7, 2018

Thanks for fixing the typo. 👍

To pass the format check, try

$ rustup component add rustfmt-preview
$ cargo fmt --all -- --check

It would fix it for you.

@frozencemetery
Copy link
Contributor

Thanks @lukehinds, this looks good! Don't worry about the Travis failure; rustfmt seems to have changed under us. Will merge shortly.

@lukehinds
Copy link
Member Author

Thanks @leonjia0112 , so the lint errors have crossed over from the master branch.

I can fix these by just running with --check, may as well do this in this branch and we can look at the diffs.

@frozencemetery
Copy link
Contributor

Hah, that works too :)

@frozencemetery frozencemetery merged commit 0f3da94 into keylime:master Dec 7, 2018
@lukehinds
Copy link
Member Author

Sorry @frozencemetery missed your previous comment somehow (comment race condition!). All looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants