Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log #31

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fix log #31

merged 1 commit into from
Dec 21, 2018

Conversation

leonjia0112
Copy link
Contributor

@leonjia0112 leonjia0112 commented Dec 11, 2018 •
edited
Loading

Add a function in the testing suite to initialize the logger. So the command

RUST_LOG=keylime_node=trace cargo test

would work.

Test passed. Ready for a review.
Thanks!

frozencemetery
frozencemetery suggested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@frozencemetery frozencemetery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra commit in here. Clean your diffs.

@leonjia0112 leonjia0112 force-pushed the fix-log branch 4 times, most recently from 02f2591 to 6d157a3 Compare December 12, 2018 22:07
@leonjia0112
Copy link
Contributor Author

leonjia0112 commented Dec 12, 2018 •
edited
Loading

Now, this commit only fixes the no logging bug in testing suite.
Rebased onto commit #16

Test passed. Ready for a review.
Thanks.

@leonjia0112 leonjia0112 force-pushed the fix-log branch 2 times, most recently from 4324e18 to c4c69ef Compare December 13, 2018 19:38
@frozencemetery frozencemetery merged commit b3fc9be into keylime:master Dec 21, 2018
@frozencemetery frozencemetery mentioned this pull request Dec 21, 2018
Closed
@leonjia0112 leonjia0112 deleted the fix-log branch March 13, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonjia0112 @frozencemetery