Make support for legacy python revocation actions optional #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
reviewed
May 16, 2022
src/main.rs
Outdated
| "Could not find python shim at {}", | ||
| python_shim.display() | ||
| ))); | ||
| if cfg!(feature = "legacy-python-actions") { |
There was a problem hiding this comment.
What about using cfg_if! to compile out unnecessary code?
There was a problem hiding this comment.
OK, I'll modify the code to use cfg_if!
ansasaki
force-pushed
the
optional_shim
branch
2 times, most recently
from
5ba6dc1 to
7fdbc39
Compare
ansasaki
changed the title
Add the 'legacy-python-actions' feature, enabled by default, to control whether the agent supports python revocation actions loaded as modules. Note that this is the only kind of revocation actions script supported by the python agent implementation, which means that removing this feature will make existing revocation actions unusable. Disabling the 'legacy-python-actions' feature will not disable the support for running stand-alone python revocation action scripts, i.e. executable python scripts can be used as a revocation actions scripts, as well as any other executable. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the 'legacy-python-actions' feature, enabled by default, to control
whether the agent supports python revocation actions loaded as modules.
Note that this is the only kind of revocation actions script supported
by the python agent implementation, which means that removing this
feature will make existing revocation actions unusable.
Disabling the 'legacy-python-actions' feature will not disable the
support for running stand-alone python revocation action scripts, i.e.
executable python scripts can be used as a revocation actions scripts,
as well as any other executable.
Fixes: #368
Signed-off-by: Anderson Toshiyuki Sasaki [email protected]