-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hash_ek UUID creation #385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THS-on
force-pushed
the
hash_ek
branch
2 times, most recently
from
May 26, 2022 15:05
1c8004c
to
c9e9c08
Compare
lkatalin
approved these changes
Jun 3, 2022
Signed-off-by: Thore Sommer <[email protected]>
ueno
reviewed
Jun 3, 2022
Signed-off-by: Thore Sommer <[email protected]>
With that create_ek(..) now also returns the TPM Public structure. Signed-off-by: Thore Sommer <[email protected]>
Signed-off-by: Thore Sommer <[email protected]>
ueno
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; thanks for the clean up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tss-esapi crate provides now the conversion functions for Public to a more standard key format.
This PR first updates to the newest tss-esapi version and then implements the hash_ek option for UUID creation.