Drop unused rustc-serialize and flate2 dependencies and make wiremock optional #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
approved these changes
Jun 9, 2022
lkatalin
approved these changes
Jun 9, 2022
ueno
reviewed
Jun 10, 2022
ansasaki
force-pushed
the
drop_dependencies
branch
from
703c26d to
c1916f8
Compare
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Make a wiremock optional, enabled when the 'testing' feature is enabled. The goal is to reduce the number of dependencies, with the downside that the test code coverage will drop. Wiremock is currently used only on 'registrar_agent' tests to mock responses from the registrar service. Note: wiremock was moved to be an optional regular dependency because optional dev-dependencies are not supported. see: rust-lang/cargo#1596 Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
drop_dependencies
branch
from
c1916f8 to
c31174a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop unused
rustc-serializeandflate2dependencies and makewiremockan optional dependency used when thetestingfeature is enabled.Fixes #301