Handle whitespace in keylime.conf

src/common.rs

@@ -459,11 +459,19 @@ impl KeylimeConfig {
             Ok(s) => bool::from_str(&s.to_lowercase())?,
             Err(_) => ALLOW_PAYLOAD_REV_ACTIONS,
         };
+
         let run_as = if permissions::get_euid() == 0 {
             match config_get(&conf_name, &conf, "cloud_agent", "run_as") {
-                Ok(user_group) => Some(user_group),
+                Ok(user_group) => {
+                    if user_group.is_empty() {
+                        warn!("Cannot drop privileges since 'run_as' is empty in 'cloud_agent' section of keylime.conf.");
+                        None
+                    } else {
+                        Some(user_group)
+                    }
+                }
                 Err(_) => {
-                    warn!("Cannot drop privileges since 'run_as' is empty or missing in 'cloud_agent' section of keylime.conf.");
+                    warn!("Cannot drop privileges since 'run_as' is missing in 'cloud_agent' section of keylime.conf.");
                     None
                 }
             }
@@ -698,7 +706,7 @@ fn config_get(
         }
     };
     let value = match section.get(key) {
-        Some(value) => value,
+        Some(value) => value.trim(),
         None =>
         // TODO: Make Error::Configuration an alternative with data instead of string
         {
@@ -709,6 +717,10 @@ fn config_get(
         }
     };
 
+    if value.is_empty() {
+        warn!("Cannot find value for key {} in file {}", key, conf_name);
+    };
+
     Ok(value.to_string())
 }
 

src/main.rs

@@ -408,7 +408,12 @@ async fn main() -> Result<()> {
     // Drop privileges
     if let Some(user_group) = &config.run_as {
         permissions::chown(user_group, &mount);
-        permissions::run_as(user_group);
+        if let Err(e) = permissions::run_as(user_group) {
+            let message = "The user running the Keylime agent should be set in keylime.conf, using the parameter `run_as`, with the format `user:group`".to_string();
+
+            error!("Configuration error: {}", &message);
+            return Err(Error::Configuration(message));
+        }
     }
 
     info!("Starting server with API version {}...", API_VERSION);