Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm: Add serialization functions for structures in quotes #411

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

ansasaki
Copy link
Contributor

Add serialization and deserialization functions for the data in quotes
to avoid endianness issues when the arch is big-endian.

The added serialization and deserialization functions will convert the
data endianness as necessary.

Note: the official marshalling and unmarshalling functions cannot be
used directly because the tpm2-tools uses a custom format.

Fixes: #407

Signed-off-by: Anderson Toshiyuki Sasaki [email protected]

src/tpm.rs Outdated Show resolved Hide resolved
src/tpm.rs Outdated Show resolved Hide resolved
src/tpm.rs Outdated Show resolved Hide resolved
src/tpm.rs Outdated Show resolved Hide resolved
src/tpm.rs Outdated Show resolved Hide resolved
Add serialization and deserialization functions for the data in quotes
to avoid endianness issues when the arch is big-endian.

The added serialization and deserialization functions will convert the
data endianness as necessary.

Note: the official marshalling and unmarshalling functions cannot be
used directly because the tpm2-tools uses a custom format.

Fixes: keylime#407

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Copy link
Contributor

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keylime-bot keylime-bot assigned lukehinds and ashcrow and unassigned ansasaki Jun 24, 2022
@ansasaki ansasaki merged commit 7f98151 into keylime:master Jun 24, 2022
@ansasaki ansasaki deleted the endianness branch June 24, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPM quote decoding fails on s390x arch
4 participants