Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show path when fail to load the certificate #412

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Jun 22, 2022

When we try to load the mTLS certificate but it is missing, a generic
error is shown: "No such file or directory".

This commit introduces an error! log showing the full path of the
missing certificate.

Signed-off-by: Alberto Planas [email protected]

@THS-on
Copy link
Member

THS-on commented Jun 22, 2022

I implemented something similar in #410, but this is cleaner than my implementation.

@aplanas
Copy link
Contributor Author

aplanas commented Jun 22, 2022

I implemented something similar in #410

Ouch! Sorry!

When we try to load the mTLS certificate but it is missing, a generic
error is shown: "No such file or directory".

This commit introduces an error! log showing the full path of the
missing certificate.

Fix keylime#389

Signed-off-by: Alberto Planas <[email protected]>
@ansasaki
Copy link
Contributor

/packit retest-failed

Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my POV. I'll defer to @lkatalin for second review and merge.

src/main.rs Show resolved Hide resolved
Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lkatalin lkatalin merged commit dbefd86 into keylime:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants