Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNUmakefile: Make target dependencies explicit #421

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

ueno
Copy link
Contributor

@ueno ueno commented Jun 30, 2022

Previously, at "make install" the programs are always rebuilt with
cargo, even if they already exist as a result of prior invocation of
"make", which causes a problem if cargo is installed locally for the
user with rustup. This adds explicit prerequisites to the build
target to avoid that.

Fixes: #420
Signed-off-by: Daiki Ueno [email protected]

Previously, at "make install" the programs are always rebuilt with
cargo, even if they already exist as a result of prior invocation of
"make", which causes a problem if cargo is installed locally for the
user with rustup.  This adds explicit prerequisites to the build
target to avoid that.

Signed-off-by: Daiki Ueno <[email protected]>
Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this seems to fix the error. Thanks @ueno !

@lkatalin lkatalin merged commit 22e805d into keylime:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo command in makefile does not interact well with permissions
4 participants