Add run_as in keylime.conf and avoid executing as root #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aplanas Could you resolve the conflict? |
|
@lkatalin, should be done! Do you want me to change the |
lkatalin
reviewed
Jul 26, 2022
|
Thank you, lgtm! Needs one more rebase and it should be good to go. |
Signed-off-by: Alberto Planas <[email protected]>
If `run_as` parameter is set but the user is missing in the system, keylime will log an ERROR when trying to drop privileges, but continue the execution as the current user (usually `root`). This can be a security issue, as the agent is running "silently" as a privileged user. This commit stop the execution if an error is found when dropping privileges for the agent service, and present an `info!` message with the current user and group. Signed-off-by: Alberto Planas <[email protected]>
|
@lkatalin Rebased, but I did not found any new conflict. |
ashcrow
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add run_as in keylime.conf
If
run_asparameter is set but the user is missing in the system,keylime will log an ERROR when trying to drop privileges, but continue
the execution as the current user (usually
root). This can be asecurity issue, as the agent is running "silently" as a privileged user.
This commit stop the execution if an error is found when dropping
privileges for the agent service, and present an
info!message withthe current user and group.