-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tpm: Respect ek_handle from config #426
Conversation
485c792
to
d74d80d
Compare
Test log says: |
f6b0fe8
to
0bbf0b0
Compare
0f76785
to
af5e64d
Compare
af5e64d
to
0fac890
Compare
@ueno I see some TPM password and owner auth related code - we're not trying to take ownership of the TPM here, right? |
149a209
to
fbd3a62
Compare
Thanks @ueno. The password seems okay to access the EK as long as the agent doesn't take ownership of the TPM. |
This adds support for the "ek_handle" option in the cloud_agent configuration, which previously was not checked and a new EK was always generated. This also adds partial support for "tpm_ownerpassword" for the use with "ek_handle". Signed-off-by: Daiki Ueno <[email protected]>
fbd3a62
to
badaf2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <[email protected]>
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <[email protected]>
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <[email protected]>
@kkaarreell I opened #433 |
The option has been introduced in keylime#426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <[email protected]>
The option has been introduced in #426 but keylime.conf has not been updated with it. Signed-off-by: Karel Srot <[email protected]>
Previously it always generated new EK handle even if the "ek_handle"
option is set to use the existing key.
Signed-off-by: Daiki Ueno [email protected]