Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSL bindings for RSA public key import and random RSA key generation #43

Merged
merged 3 commits into from
Jan 25, 2019

Conversation

mbestavros
Copy link
Contributor

This is a work-in-progress pull request that implements bindings for two crypto functions necessary for the implementation of the Keylime Rust client (as per @leonjia0112). These also constitute a part of the crypto interface as specified in #20. Documentation for both functions is included inline.

Some notes to keep in mind:

  • Per offline discussion with @leonjia0112 and @frozencemetery, we will be building our own error type to reconcile the different varieties of error the entire client will be dealing with, as documented in Own error type #42. For this reason, error handling should be considered incomplete for these bindings -- with the expectation that the functions should be revised to work with the new error type once it's been implemented.
  • Tests do not yet exist for either function -- they should be added in after we implement our own error variety as specified above.

Tagging @frozencemetery and @leonjia0112 for review.

Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections at this time, though you do need to pass CI.

@mbestavros mbestavros force-pushed the ljia-blocking-bindings branch from 53820bb to a4544af Compare January 24, 2019 19:53
@mbestavros
Copy link
Contributor Author

mbestavros commented Jan 24, 2019

@frozencemetery: Fixed up formatting issues with my additions, and added another commit for a missing semicolon in secure_mount.rs that was causing rustfmt to fail.

@frozencemetery frozencemetery merged commit 8bbd809 into keylime:master Jan 25, 2019
@mbestavros mbestavros deleted the ljia-blocking-bindings branch January 25, 2019 18:52
@mbestavros mbestavros mentioned this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants