Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: mark Rust agent as the offical one, fix cargo run command #466

Merged
merged 1 commit into from
Oct 17, 2022
Merged

README: mark Rust agent as the offical one, fix cargo run command #466

merged 1 commit into from
Oct 17, 2022

Conversation

THS-on
Copy link
Member

@THS-on THS-on commented Oct 5, 2022

This removes the disclaimer that the rust agent should not used in production and replaces it with that this agent is now the official one.

ueno
ueno approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message ("offical" → "official"); otherwise looks good to me.

@THS-on THS-on force-pushed the production-readme branch from 0f829a3 to 48482f0 Compare October 6, 2022 06:22
@THS-on
Copy link
Member Author

THS-on commented Oct 6, 2022

@ueno fixed.

lukehinds
lukehinds approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t!

@lkatalin
Copy link
Contributor

Fixes #437

lkatalin
lkatalin approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lkatalin lkatalin merged commit f5de47b into keylime:master Oct 17, 2022
@lkatalin lkatalin mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkatalin lkatalin lkatalin approved these changes

@lukehinds lukehinds lukehinds approved these changes

@ueno ueno ueno approved these changes

@puiterwijk puiterwijk Awaiting requested review from puiterwijk

Assignees

@puiterwijk puiterwijk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@THS-on @lkatalin @ueno @lukehinds @puiterwijk