Cargo.toml: tss-esapi bindings #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
approved these changes
Jan 17, 2023
|
I will fix the commit message, but I will drop the changes in the lock file, I think that they should not be there |
aplanas
force-pushed
the
fix_tss-essapi
branch
from
b1b070d to
df18e7f
Compare
|
Should me done, tested here: https://build.opensuse.org/package/show/home:aplanas:branches:security/rust-keylime and we have ppc and s390x binaries : ) |
|
cargo audit detects an issue that the unmaintained Maybe we need a bump of bindgen requirement in rust-tss-esapi to 0.60 at least? |
aplanas
added a commit
to aplanas/rust-tss-esapi
that referenced
this pull request
Jan 18, 2023
The optional bindgen dependency was set to a version that depends on an old version of clap, and also depends on the ansi_term crate, now unmaintained and causing audit complains. See [1] for an example. This patch upgrade to bindgen 0.63.0 and drop the dependency to the affected crate. [1] keylime/rust-keylime#502 Signed-off-by: Alberto Planas <[email protected]>
Done here: parallaxsecond/rust-tss-esapi#386 |
aplanas
added a commit
to aplanas/rust-tss-esapi
that referenced
this pull request
Jan 18, 2023
The optional bindgen dependency was set to a version that depends on an old version of clap, and also depends on the ansi_term crate, now unmaintained and causing audit complains. See [1] for an example. This patch upgrade to bindgen 0.60.0 and drop the dependency to the affected crate. In the future we should update 0.63, but in this case the minimal rustc version required will be 1.57 [1] keylime/rust-keylime#502 Signed-off-by: Alberto Planas <[email protected]>
aplanas
added a commit
to aplanas/rust-tss-esapi
that referenced
this pull request
Jan 18, 2023
The optional bindgen dependency was set to a version that depends on an old version of clap, and also depends on the ansi_term crate, now unmaintained and causing audit complains. See [1] for an example. This patch upgrade to bindgen 0.63.0 and drop the dependency to the affected crate. [1] keylime/rust-keylime#502 Signed-off-by: Alberto Planas <[email protected]>
Generate the tss-esapi bindings during compilation time. This will extend the amount of supported architectures. This is a regression done after the crate split, that was fixed before in keylime#459. Signed-off-by: Alberto Planas <[email protected]>
ansasaki
force-pushed
the
fix_tss-essapi
branch
from
df18e7f to
9b6a16a
Compare
|
/packit retest-failed |
aplanas
added a commit
to aplanas/rust-tss-esapi
that referenced
this pull request
Feb 2, 2023
The optional bindgen dependency was set to a version that depends on an old version of clap, and also depends on the ansi_term crate, now unmaintained and causing audit complains. See [1] for an example. This patch upgrade to bindgen 0.63.0 and drop the dependency to the affected crate. [1] keylime/rust-keylime#502 Signed-off-by: Alberto Planas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the tss-esapi bindings during compilation time. This will extend the ammount of supported architectures.
This is a regression done after the crate split, that was fixed before in #459.
Signed-off-by: Alberto Planas [email protected]