crypto, mTLS: allow certificate chain for trusted_client_ca #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
requested changes
Feb 2, 2023
This allows for setups with intermediate CAs. Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
4a61ddf to
f9446c4
Compare
|
LGTM! Could you please fix that line clippy is complaining about? |
|
@ansasaki done |
|
It seems like that something has changed how clippy deals with references of strings. My local version of clippy (0.1.67) does not report it. I'll update the rest of issues later. |
Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
afb8529 to
db2d1b4
Compare
|
It is complaining now about the string interpolation |
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
38d4000 to
144b933
Compare
@aplanas should be fixed now. |
aplanas
reviewed
Feb 8, 2023
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
144b933 to
0b1e9ab
Compare
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
0b1e9ab to
18bfd9a
Compare
aplanas
reviewed
Feb 8, 2023
| error!( | ||
| "Failed to load trusted CA certificate {}: {}", | ||
| ca_cert_path.display(), | ||
| e |
There was a problem hiding this comment.
clippy should complain here too, shouldn't?
There was a problem hiding this comment.
No because you cannot call functions currently in a fromat string, I think.
There was a problem hiding this comment.
Yeah, I don't know. I would keep it this way for now, because mixing the two styles looks wrong.
Signed-off-by: Thore Sommer <[email protected]>
Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
bug/mtls-cert-chain
branch
from
18bfd9a to
d500481
Compare
ansasaki
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for setups with intermediate CAs.