Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage for rust agent as github action #512

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Coverage for rust agent as github action #512

merged 1 commit into from
Feb 28, 2023

Conversation

Koncpa
Copy link
Contributor

@Koncpa Koncpa commented Feb 2, 2023

Implement github action which gather code coverage of PR against master branch. And after merge it gather code coverage again. Add helper script which gather code coverage from testing farm. And update e2e plan where run tasks for measuring code coverage.

Signed-off-by: Patrik Koncity [email protected]

@Koncpa Koncpa force-pushed the tarpaulin_codecov branch 3 times, most recently from 2642599 to fdc10ca Compare February 2, 2023 12:23
@Koncpa
Copy link
Contributor Author

Koncpa commented Feb 2, 2023

Hi guys,
for proper function of gathering code coverage for merged PR is it mandatory to have
TESTING_FARM_API_TOKEN to access to TF machines. It can be used same token which is used already for keylime repository. Or you can get new one via this steps. After you get the token you need to add as action secrets named as TESTING_FARM_API_TOKEN. @THS-on @mpeters

@Koncpa Koncpa force-pushed the tarpaulin_codecov branch from fdc10ca to 0319385 Compare February 2, 2023 12:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1b8cd8b). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #512   +/-   ##
=========================================
  Coverage          ?   53.00%           
=========================================
  Files             ?       22           
  Lines             ?     8061           
  Branches          ?        0           
=========================================
  Hits              ?     4273           
  Misses            ?     3788           
  Partials          ?        0
Flag Coverage Δ
e2e-testsuite 49.80% <0.00%> (?)
upstream-unit-tests 58.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Koncpa Koncpa force-pushed the tarpaulin_codecov branch 9 times, most recently from 0fbd5cf to 02dfebe Compare February 7, 2023 13:37
aplanas
aplanas reviewed Feb 8, 2023
View reviewed changes
.github/workflows/submit-HEAD-coverage.yaml Outdated Show resolved Hide resolved
packit-ci.fmf Outdated Show resolved Hide resolved
packit-ci.fmf Outdated Show resolved Hide resolved
@Koncpa Koncpa force-pushed the tarpaulin_codecov branch 6 times, most recently from da84e21 to 112084b Compare February 9, 2023 12:45
@Koncpa Koncpa force-pushed the tarpaulin_codecov branch 11 times, most recently from 0447258 to 5051383 Compare February 27, 2023 13:01
@Koncpa Koncpa changed the title WIP: Coverage for rust agent as github action. Coverage for rust agent as github action. Feb 27, 2023
@Koncpa Koncpa changed the title Coverage for rust agent as github action. Coverage for rust agent as github action Feb 27, 2023
@Koncpa Koncpa force-pushed the tarpaulin_codecov branch 13 times, most recently from c5abebb to 2fb6914 Compare February 28, 2023 08:32
@Koncpa
Coverage for rust agent as github action.
2fb6914 
Implement github action which gather code coverage
of PR against master branch. And after merge it gather
code coverage again. Add helper script which gather code
coverage from testing farm. And update e2e plan where
run tasks for measuring code coverage.

Signed-off-by: Patrik Koncity <[email protected]>
@Koncpa
Copy link
Contributor Author

Koncpa commented Feb 28, 2023

Probably it will fails for fedora-rawhide, but it this case is not relevant, code coverage is measured only for f37 and cs9.

ansasaki
ansasaki approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Failures in Fedora Rawhide are expected, due to:
tpm2-software/tpm2-tools#3210
https://bugzilla.redhat.com/show_bug.cgi?id=2171376

@ansasaki ansasaki merged commit 2b217a1 into keylime:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aplanas aplanas aplanas left review comments

@ansasaki ansasaki ansasaki approved these changes

@ueno ueno Awaiting requested review from ueno

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees

@ueno ueno

@lukehinds lukehinds

@ansasaki ansasaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Koncpa @codecov-commenter @aplanas @ansasaki @ueno @lukehinds