Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo deb: include shim.py in packaging #517

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

THS-on
Copy link
Member

@THS-on THS-on commented Feb 15, 2023

No description provided.

@ashcrow
Copy link
Contributor

ashcrow commented Feb 15, 2023

Looks like the failure is in a package conflict. Likely not related to the change here.

@THS-on
Copy link
Member Author

THS-on commented Feb 15, 2023

Looks like the failure is in a package conflict. Likely not related to the change here.

@ashcrow yes the issue is known, but not yet fixed. I think we can merge this.

@ashcrow ashcrow merged commit 6df6c5e into keylime:master Feb 15, 2023
@aplanas
Copy link
Contributor

aplanas commented Feb 16, 2023

So I guess that Debian is deploying the version that support the Python interface (legacy-python-actions)?

In openSUSE we are compiling it without Python support (--no-default-features --features "with-zmq"), so there is not requirement of having Python installed in the nodes

@THS-on
Copy link
Member Author

THS-on commented Feb 16, 2023

Yeah the current cargo deb package is build with all the features enabled.

@ansasaki
Copy link
Contributor

On Fedora legacy-python-actions is disabled but with-zmq is enabled. On RHEL both are disabled.

I propose we deprecate legacy-python-actions and with-zmq before the next tag/release. Then, on next major release we could remove the support completely.

@aplanas
Copy link
Contributor

aplanas commented Feb 16, 2023

I propose we deprecate legacy-python-actions and with-zmq

I agree!

So can be OK to remove "with-zmq"?

@ansasaki
Copy link
Contributor

So can be OK to remove "with-zmq"?

In my opinion, yes. I think that using REST API for revocation notifications support is sufficient.

@THS-on
Copy link
Member Author

THS-on commented Feb 16, 2023

I propose we deprecate legacy-python-actions and with-zmq before the next tag/release. Then, on next major release we could remove the support completely.

Yes sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants