-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Fedora packages on Copr using packit #546
Conversation
6268056
to
0f87e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe it time to archive this:
https://github.com/keylime/keylime-rpm
https://github.com/keylime/keylime-deb
@ansasaki it looks like that the Fedora builds are failing because the rust tss bindings cannot be found:
@aplanas agree they are way out-of-date and probably not really useful anymore. Can you raise that in the Slack channel? |
Yes, I'm aware, but these packages are not maintained by us. Basically all attempts to update the rust agent on Fedora was blocked by a problem on their side (or on A workaround to make it to build would be to use vendored versions of all dependencies on Fedora too (like how it is done in RHEL/CentOS), but we would lose good insight on the state of the dependencies on Fedora. I think I'll create exceptions for these older Fedora versions to make them work with vendored dependencies. From Fedora 38 onwards I'll keep using the system dependencies. |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
The RPM's were built successfully using the vendored dependencies. I'll rebase, drop the temporary commit, and merge. |
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Build Fedora packages on Copr when new commits are pushed to master branch.
This includes a specfile similar to one used downstream on Fedora, and a patch to make the build to use the dependencies version that are available on Fedora.
EDIT: For CentOS Stream I need to do some extra steps as it needs all dependencies to be vendored.