Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Fedora packages on Copr using packit #546

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ansasaki
Copy link
Contributor

@ansasaki ansasaki commented Mar 28, 2023

Build Fedora packages on Copr when new commits are pushed to master branch.

This includes a specfile similar to one used downstream on Fedora, and a patch to make the build to use the dependencies version that are available on Fedora.

EDIT: For CentOS Stream I need to do some extra steps as it needs all dependencies to be vendored.

Copy link
Contributor

@aplanas aplanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THS-on
Copy link
Member

THS-on commented Mar 31, 2023

@ansasaki it looks like that the Fedora builds are failing because the rust tss bindings cannot be found:

Error: 
 Problem 1: nothing provides requested (crate(tss-esapi/default) >= 7.2.0 with crate(tss-esapi/default) < 8.0.0~)
 Problem 2: nothing provides requested (crate(tss-esapi/generate-bindings) >= 7.2.0 with crate(tss-esapi/generate-bindings) < 8.0.0~)

Full log: https://download.copr.fedorainfracloud.org/results/packit/keylime-rust-keylime-546/fedora-36-x86_64/05718845-keylime-agent-rust/builder-live.log.gz

@aplanas agree they are way out-of-date and probably not really useful anymore. Can you raise that in the Slack channel?

@ansasaki
Copy link
Contributor Author

ansasaki commented Apr 3, 2023

@ansasaki it looks like that the Fedora builds are failing because the rust tss bindings cannot be found:

Error: 
 Problem 1: nothing provides requested (crate(tss-esapi/default) >= 7.2.0 with crate(tss-esapi/default) < 8.0.0~)
 Problem 2: nothing provides requested (crate(tss-esapi/generate-bindings) >= 7.2.0 with crate(tss-esapi/generate-bindings) < 8.0.0~)

Full log: https://download.copr.fedorainfracloud.org/results/packit/keylime-rust-keylime-546/fedora-36-x86_64/05718845-keylime-agent-rust/builder-live.log.gz

Yes, I'm aware, but these packages are not maintained by us. Basically all attempts to update the rust agent on Fedora was blocked by a problem on their side (or on tpm2-tools which is also not maintained by us).

A workaround to make it to build would be to use vendored versions of all dependencies on Fedora too (like how it is done in RHEL/CentOS), but we would lose good insight on the state of the dependencies on Fedora.

I think I'll create exceptions for these older Fedora versions to make them work with vendored dependencies. From Fedora 38 onwards I'll keep using the system dependencies.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #546 (ab33458) into master (6887175) will not change coverage.
The diff coverage is n/a.

❗ Current head ab33458 differs from pull request most recent head 20e8b2d. Consider uploading reports for the commit 20e8b2d to get more accurate results

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.72% <ø> (ø)
upstream-unit-tests 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ansasaki
Copy link
Contributor Author

ansasaki commented Apr 4, 2023

The RPM's were built successfully using the vendored dependencies. I'll rebase, drop the temporary commit, and merge.

@ansasaki ansasaki merged commit 19dfc67 into keylime:master Apr 4, 2023
@ansasaki ansasaki deleted the copr_build branch April 4, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants