Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packit: Build RPM packages on Copr for fedora-all #565

Merged
merged 2 commits into from
Apr 24, 2023
Merged

packit: Build RPM packages on Copr for fedora-all #565

merged 2 commits into from
Apr 24, 2023

Conversation

ansasaki
Copy link
Contributor

@ansasaki ansasaki commented Apr 14, 2023 •
edited
Loading

Enable building RPM packages on Copr for all active Fedora versions

On Fedora-38 and current Rawhide, it is not possible to build the keylime agent due to the issues:

This makes the RPM build to use vendored dependencies for all Fedora versions.

@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #565 (6d65ebd) into master (9982012) will decrease coverage by 4.47%.
The diff coverage is n/a.

❗ Current head 6d65ebd differs from pull request most recent head 7b07b8a. Consider uploading reports for the commit 7b07b8a to get more accurate results

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.83% <ø> (ø)
upstream-unit-tests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@ansasaki ansasaki force-pushed the copr_fedora branch 2 times, most recently from c4aec4d to 6bd4b39 Compare April 17, 2023 08:38
@ansasaki ansasaki mentioned this pull request Apr 21, 2023
Merged
ansasaki added 2 commits April 24, 2023 09:49
@ansasaki
packit: Enable building RPM on Copr for fedora-all
42c8c02 
Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki
rpm/fedora: Use vendored dependencies for all versions
7b07b8a 
Due to tpm2-software/tpm2-tools#3210 and
missing rust-base64 version 0.13, it is currently not possible to build
using system installed dependencies on Fedora-38 and Rawhide.

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki
Copy link
Contributor Author

/packit retest-failed

@ansasaki
Copy link
Contributor Author

The failure on Fedora 38 is due to the test not installing the latest tpm2-tools version, probably because the images used for testing have not been updated yet.

This change will allow us to use pre-compiled binaries for all tested Fedora versions, speeding up the workflow.

@ashcrow @sergio-correia @aplanas @lkatalin Could someone please approve this?

@ansasaki
Copy link
Contributor Author

Thank you! I'll drop the temporary commit and merge

@ansasaki ansasaki merged commit b14fb67 into keylime:master Apr 24, 2023
@ansasaki ansasaki deleted the copr_fedora branch April 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aplanas aplanas aplanas approved these changes

@ueno ueno Awaiting requested review from ueno

@maugustosilva maugustosilva Awaiting requested review from maugustosilva

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees

@ueno ueno

@maugustosilva maugustosilva

@lukehinds lukehinds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ansasaki @aplanas @ueno @maugustosilva @lukehinds