Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keylime-agent/src: update API version to 2.1 to consistent with https//github.com/keylime/keylime/blob/master/docs/rest_apis.rst #588

Merged
merged 1 commit into from
May 29, 2023

Conversation

hustliyilin
Copy link
Contributor

@hustliyilin hustliyilin commented May 15, 2023

Fixes #589

Signed-off-by: YiLin.Li [email protected]

Copy link
Contributor

@aplanas aplanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 2.1 changelog I can see that they removed the vmask parameter, but I still can see some references in the quotes_handler.rs test code (and some comments).

The other change seems to affect the verifier, so I am not sure that has an impact here.

@ansasaki do you know if beside the quotes_handlers change, more changes are required?

@hustliyilin
Copy link
Contributor Author

Thanks @aplanas. Currently, the rust-keylime only supports RESTful API v2.0. When using the https://github.com/keylime/keylime/blob/master/docs/rest_apis.rst, it will be an error like #588 .

image

So we need to update the API version in the rust-keylime agent or add corresponding instructions to the corresponding REST API documentation. I'm not sure which way is better.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #588 (c141442) into master (1f32de1) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.90% <50.00%> (-0.10%) ⬇️
upstream-unit-tests 58.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
keylime-agent/src/common.rs 70.62% <0.00%> (ø)
keylime-agent/src/errors_handler.rs 53.96% <ø> (ø)
keylime-agent/src/quotes_handler.rs 51.08% <100.00%> (ø)

... and 1 file with indirect coverage changes

@THS-on
Copy link
Member

THS-on commented May 24, 2023

@aplanas yeah the only change for the agent should be that we no longer send the vmask parameter.

@hustliyilin
Copy link
Contributor Author

@aplanas yeah the only change for the agent should be that we no longer send the vmask parameter.

Thanks @THS-on . @aplanas Could you review this PR again?

Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki ansasaki merged commit d3aafce into keylime:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't support the RESTful API v2.1 in https://github.com/keylime/keylime/blob/master/docs/rest_apis.rst
6 participants