-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keylime-agent/src: update API version to 2.1 to consistent with https//github.com/keylime/keylime/blob/master/docs/rest_apis.rst #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 2.1 changelog I can see that they removed the vmask parameter, but I still can see some references in the quotes_handler.rs test code (and some comments).
The other change seems to affect the verifier, so I am not sure that has an impact here.
@ansasaki do you know if beside the quotes_handlers change, more changes are required?
Thanks @aplanas. Currently, the rust-keylime only supports RESTful API v2.0. When using the https://github.com/keylime/keylime/blob/master/docs/rest_apis.rst, it will be an error like #588 . So we need to update the API version in the rust-keylime agent or add corresponding instructions to the corresponding REST API documentation. I'm not sure which way is better. |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@aplanas yeah the only change for the agent should be that we no longer send the vmask parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #589
Signed-off-by: YiLin.Li [email protected]