Remove MOUNT_SECURE bool #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ansasaki
reviewed
May 25, 2023
| let path = "/var/lib/keylime"; | ||
| let work_dir = Path::new(&path); | ||
| let secure_dir_path = Path::new(work_dir).join("secure"); | ||
| let temp_workdir = tempfile::tempdir().unwrap(); //#[allow_ci] |
There was a problem hiding this comment.
I suggest you keep the "secure" to force mount() to create the directory. It will increase the coverage. Something like:
Suggested change
| let temp_workdir = tempfile::tempdir().unwrap(); //#[allow_ci] | |
| let temp_workdir = tempfile::tempdir().unwrap(); //#[allow_ci] | |
| let secure_dir_path = Path::new(temp_workdir).join("secure"); |
There was a problem hiding this comment.
Actually it seems that this decreased code coverage a lot from point of secure mount.
Koncpa
force-pushed
the
pk_secure_mount
branch
5 times, most recently
from
5716832 to
a21ce09
Compare
Remove MOUNT_SECURE bool and conditional related with bool.Update secure mount unit test to mount temp dir. Signed-off-by: Patrik Koncity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MOUNT_SECURE bool and conditional
related with bool.Update secure mount
unit test to mount temp dir.