Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto.rs #63

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Update crypto.rs #63

merged 1 commit into from
Apr 26, 2019

Conversation

leonjia0112
Copy link
Contributor

@leonjia0112 leonjia0112 commented Apr 15, 2019

This is an example implementation of a hardcoded long string,
which rust-fmt won't be able to take the case of. Use format!()
to concentrate long two short string to create a long string,
instead of putting a single long string together.

@leonjia0112 leonjia0112 force-pushed the patch-2 branch 4 times, most recently from 98c865a to f4627f5 Compare April 15, 2019 20:39
Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to how to write a git commit message. In particular, the subject of this commit isn't useful (I know that it updates crypto.rs from the files changed already...) and more importantly I have no idea why this change is being made.

@leonjia0112
Copy link
Contributor Author

Please refer to how to write a git commit message. In particular, the subject of this commit isn't useful (I know that it updates crypto.rs from the files changed already...) and more importantly I have no idea why this change is being made.

I feel like the string is too long in here, which can be shortened a little bit. For such kind of thing, rustfmt won't take care of it. But I will update the commit message to make it a little more meaningful.

This is an example implementation of a hardcoded long string,
which rust-fmt won't be able to take the case of. Use format!()
to concentrate long two short string to create a long string,
instead of putting a single long string together.
@leonjia0112
Copy link
Contributor Author

Change addressed and test passed.
Ready for a review. @frozencemetery @mbestavros

@frozencemetery frozencemetery merged commit 93aaf4a into keylime:master Apr 26, 2019
@leonjia0112 leonjia0112 deleted the patch-2 branch May 8, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants