Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: disable IAK/IDevID by default when no configuration is found #731

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ansasaki
Copy link
Contributor

@ansasaki ansasaki commented Feb 1, 2024

Disable the IAK/IDevID feature by default when no configuration option is found.
Install the agent configuration file in /etc/keylime/agent.conf instead of /etc/keylime/keylime-agent.conf

Fixes #729, #730

When no configuration option is found, the feature should be disabled by
default.

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Install the configuration file in /etc/keylime/agent.conf instead of
/etc/keylime/keylime-agent.conf

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a744517) 65.28% compared to head (89fd0e2) 65.28%.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 59.15% <100.00%> (ø)
upstream-unit-tests 52.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keylime-agent/src/config.rs 78.40% <100.00%> (ø)

@ansasaki ansasaki changed the title config: IAK/IDevID default when no configuration is found config: disable IAK/IDevID by default when no configuration is found Feb 1, 2024
@ansasaki ansasaki merged commit c30c5fb into keylime:master Feb 1, 2024
18 checks passed
@ansasaki ansasaki deleted the fix_idevid_defaults branch February 1, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAK/IDevID are enabled by default and required
4 participants