crypto: Enable TLS 1.3 #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
reviewed
Mar 16, 2024
ansasaki
force-pushed
the
enable_tls13
branch
2 times, most recently
from
00355a1 to
e8505eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ueno
approved these changes
Apr 26, 2024
The agent server used the SslAcceptor::mozilla_intermediate() which disables TLS 1.3 and restricts the TLS 1.2 ciphers to: TLSv1.2: ciphers: TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (ecdh_x25519) TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (ecdh_x25519) TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 (dh 2048) TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 (dh 2048) TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 (ecdh_x25519) TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 (ecdh_x25519) TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (ecdh_x25519) TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA (ecdh_x25519) TLS_DHE_RSA_WITH_AES_128_CBC_SHA256 (dh 2048) TLS_DHE_RSA_WITH_AES_128_CBC_SHA (dh 2048) TLS_DHE_RSA_WITH_AES_256_CBC_SHA256 (dh 2048) TLS_DHE_RSA_WITH_AES_256_CBC_SHA (dh 2048) TLS_RSA_WITH_AES_128_GCM_SHA256 (rsa 4096) TLS_RSA_WITH_AES_256_GCM_SHA384 (rsa 4096) TLS_RSA_WITH_AES_128_CBC_SHA256 (rsa 4096) TLS_RSA_WITH_AES_256_CBC_SHA256 (rsa 4096) TLS_RSA_WITH_AES_128_CBC_SHA (rsa 4096) TLS_RSA_WITH_AES_256_CBC_SHA (rsa 4096) With this change TLS 1.3 is enabled. The following ciphers are accepted: TLSv1.2: ciphers: TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 (dh 2048) TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 (dh 2048) TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (secp256r1) TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (secp256r1) TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) TLSv1.3: ciphers: TLS_AKE_WITH_AES_128_GCM_SHA256 (ecdh_x25519) TLS_AKE_WITH_AES_256_GCM_SHA384 (ecdh_x25519) TLS_AKE_WITH_CHACHA20_POLY1305_SHA256 (ecdh_x25519) Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent server used the
SslAcceptor::mozilla_intermediate()which disables TLS 1.3 and restricts the TLS 1.2 ciphers to:With this change TLS 1.3 is enabled. The following ciphers are accepted: