config: Support IPv6 with or without brackets #765
Merged
+834
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
force-pushed
the
cert_san_fix
branch
4 times, most recently
from
248305d to
6b4d2ee
Compare
sarroutbi
reviewed
Mar 25, 2024
keylime/src/crypto.rs
Outdated
| let r = CertificateBuilder::new() | ||
| .private_key(privkey) | ||
| .common_name("uuidB") | ||
| .add_ips(vec!["1.2.3.4".to_string()]) |
There was a problem hiding this comment.
Why has 1.2.3.5 address been removed in this call? The idea is to test with more than one IP in the vector. Apart from that, I recommend adding also a test with a list of IPv6 tests, if possible
There was a problem hiding this comment.
Thanks for the review! I moved the unit tests to keylime/crypto/x509.rs. I also added a test using IPv6 there.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The CertificateBuilder struct follows the builder pattern to add desired parameters incrementally before generating the certificate. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
The goal of the parser is to support IPv6 addresses to be used in the configuration file with or without brackets. The provided IP addresses are validated using the standard implementation of the IP parser. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
This adds support to use IPv6 in configuraton file with or without brackets. The brackets are removed when the IP is parsed and added back when necessary. This also fix the addition of IPv6 addresses to the mTLS certificate in Subject Alternative Name extension. Fixes: keylime#583 Fixes: keylime#753 Fixes: keylime#755 Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for IPv6 addresses in the configuration with or without brackets.
The brackets are removed when the addresses are parsed and then added back when necessary.
This fixes the addition of IPv6 addresses in the mTLS certificate.
This also implements the builder pattern for the certificate generation.
Fixes: #583
Fixes: #753
Fixes: #755