config: Support hostnames in registrar_ip option #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
force-pushed
the
restore_hostname
branch
from
52d0b3d to
30b1881
Compare
|
/packit retest-failed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
To address the reduction in the test coverage, the issue RedHat-SP-Security/keylime-tests#586 was created |
maugustosilva
approved these changes
Jun 5, 2024
sergio-correia
approved these changes
Jun 5, 2024
ueno
approved these changes
Jun 5, 2024
This restores previous behavior where hostnames could be used to set the 'registrar_ip' configuration option. The configuration will try to parse the input configuration string as an IP and in case of failure, try to parse the string as a hostname. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
restore_hostname
branch
from
30b1881 to
d4becf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores previous behavior where hostnames could be used to set the 'registrar_ip' configuration option.
The configuration will try to parse the input configuration string as an IP and in case of failure, try to parse the string as a hostname.
Fixes: #794