Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic installation instructions for the Keylime RPM distribution and copy over RPM spec file #8

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

mbestavros
Copy link
Contributor

@mbestavros mbestavros commented Oct 25, 2018

Wrote up some documentation for installing the Keylime RPM package found here.

Also copied over the RPM spec file from the mainline Python Keylime repo.

Copy link
Contributor

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. In general I think this is correct. Some nits inline; also please shorten the commit message to ~50 characters

rpm/README.md Outdated
@@ -0,0 +1,25 @@
# Keylime RPM distribution

The Python version of the Keylime project (original repo by MIT Lincoln Labs [here](https://github.com/mit-ll/python-keylime)) is available as a packaged RPM. Installation instructions and related materials are available in this directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap at 78 characters, please.

rpm/README.md Outdated
@@ -0,0 +1,25 @@
# Keylime RPM distribution

The Python version of the Keylime project (original repo by MIT Lincoln Labs [here](https://github.com/mit-ll/python-keylime)) is available as a packaged RPM. Installation instructions and related materials are available in this directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap at 78 characters.

Vendor: MIT Lincoln Laboratory <[email protected]>
Url: https://github.com/mit-ll/python-keylime
AutoReq: no
Requires: epel-release, git, wget, python-setuptools >= 0.7, python-devel, gcc, automake, gcc-c++, openssl, openssl-devel, libtool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap this too.


%changelog
* Wed Jul 18 2018 Huzefa Mandviwala <[email protected]> 1.2-1
– Initial Packaging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at end of file

@mbestavros
Copy link
Contributor Author

@frozencemetery Made a few edits; ready for review again.

@frozencemetery frozencemetery merged commit 92ca370 into keylime:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants