Port run and KeylimeTpmError to unique modules
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ports the `run` function from `tpm.rs` into its own file / module `cmd_exec.rs` - primary reason for this is that non tpm functions also call on the `run` function, so its not exclusive to tpm operations (for example secure_mount uses run) For `KeylimeTpmError` - this has been ported into a module `keylime_error`, so that we can group all errors into a single module, as it makes sense that we will eventually have more error types and have them neatly self contained in single module Resolves: #81
lukehinds
commented
Oct 29, 2019
| pub fn run<'a>( | ||
| command: String, | ||
| output_path: Option<&str>, | ||
| ) -> Result<(String, String), keylime_error::KeylimeTpmError> { |
There was a problem hiding this comment.
Perhaps nit picking, but just noticed run is returning KeylimeTpmError which although works programatically, still reads wrong. If ok, I will refactor this in the tpm2 patch I am fixing up.
There was a problem hiding this comment.
That seems fine as long as we don't lose track of it.
Reinstate std::env into tpm.rs, which was mistakenly removed in main commit for PR #82
frozencemetery
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports the
runfunction fromtpm.rsinto its ownfile / module
cmd_exec.rs- primary reason for this is that nontpm functions also call on the
runfunction, so its notexclusive to tpm operations (for example secure_mount uses run)
For
KeylimeTpmError- this has been ported into a modulekeylime_error, so that we can group all errors into a singlemodule, as it makes sense that we will eventually have more
error types and have them neatly self contained in single module
Resolves: #81