Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): add Keyboard and KMXKeyboard classes 🎼 #12825

Open
wants to merge 1 commit into
base: refactor/web/jskeyboards
Choose a base branch
from
Open

feat(web): add Keyboard and KMXKeyboard classes 🎼 #12825

wants to merge 1 commit into from
+261 −164

Conversation

ermshiperete
Copy link
Contributor

The Keyboard class can be either a JS or KMX keyboard. Also make use of the Keyboard class where it makes sense and add TODOs in the places that still need to be implemented for KMX keyboard support.

Part-of: #11293
@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 11, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(web): add Keyboard and KMXKeyboard classes feat(web): add Keyboard and KMXKeyboard classes 🎼 Dec 11, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 11, 2024
@ermshiperete ermshiperete marked this pull request as draft December 11, 2024 18:50
@ermshiperete ermshiperete force-pushed the refactor/web/jskeyboards branch from 27e7418 to c359fe7 Compare December 16, 2024 17:21
@ermshiperete ermshiperete force-pushed the refactor/web/jskeyboards branch from c359fe7 to b4d78ce Compare December 20, 2024 17:04
@ermshiperete ermshiperete marked this pull request as ready for review December 20, 2024 19:26
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S18, A18S19 Jan 6, 2025
@ermshiperete
feat(web): add Keyboard and KMXKeyboard classes
bb4d5d9 
The `Keyboard` class can be either a JS or KMX keyboard. Also make use
of the `Keyboard` class where it makes sense and add TODOs in the places
that still need to be implemented for KMX keyboard support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees
No one assigned
Labels
epic-web-core feat web/
Projects
Keyman
Status: No status
Milestone
A18S19
Development

Successfully merging this pull request may close these issues.
2 participants
@ermshiperete @darcywong00