-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): use main looper to dispatch key events when OSK is hidden #12871
Conversation
User Test ResultsTest specification and instructions Test Artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Thanks for finding this!
nvm - I made the 🍒 pick in #12875 |
Test ResultsI tested this issue with the attached "18.0.166-alpha-test-12871" build(15/01/2025) on an Android 14 physical device. I'm sharing my observation here.
|
Changes in this pull request will be available for download in Keyman version 18.0.168-alpha |
Fixes: #12366
Supersedes: #12381
Alas, it would appear that we cannot rely on the
WebView
's version ofpostDelayed
, as apparently that doesn't actually trigger delayed events when theWebView
has been detached! We can, however, construct aHandler
instance and link it to the UI thread's looper in order to achieve our desired effect.User Testing
Setup - Install the PR build of Keyman for Android on a physical device. Also pair an external keyboard (USB/bluetooth) to the device
TEST_KEYBOARD - Verifies external keyboard works when virtual keyboard hidden
à
.à
Please repeat the test a few times, verifying that no errors are triggered during any attempt.