Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Shizuku for some features #746

Closed
24 tasks done
sds100 opened this issue Jul 16, 2021 · 3 comments
Closed
24 tasks done

Use Shizuku for some features #746

sds100 opened this issue Jul 16, 2021 · 3 comments
Assignees
@sds100
Labels
enhancement New feature or request

Comments

@sds100
Copy link
Collaborator

sds100 commented Jul 16, 2021 •
edited
Loading

Developer TODO (don't remove)

  • create new branch. put issue number at start of name
  • write tests before working on feature. put issue number in comment
  • check if device is at least API 23 before doing anything related to Shizuku
  • check if Shizuku is installed before asking for permission.
  • add a setting to use Shizuku where applicable
    • Show steps to grant it. like the android 11 bug workaround
      1. Install Shizuku app
      2. Start the Shizuku service
      3. Grant Key Mapper permission to use Shizuku
    • Only show this on API 23+.
  • website guide
    • 2.4.0+ only
    • go to Key Mapper settings -> Shizuku support to set this up
    • Benefits of using Shizuku with Key Mapper
    • You don't need to configure Key Mapper to use Shizuku since it will automatically and it will only ask you to grant extra permissions where Shizuku can't be used.
  • If Android 11+ prompt them to install Shizuku or the Key Mapper GUI Keyboard. List the advantages and disadvantages for both for only Key Event actions.
  • action errors should change if using shizuku.
    • If shizuku is installed show an error that it isn't started
      - [ ] dont show GUI keyboard ad if shizuku is installed. Instead prompt for Shizuku permission but also mention that the GUI keyboard to be used instead Always show it just to let the user know their options.
  • Granting WRITE_SECURE_SETTINGS
  • Inputting key events.
  • move cursor to end action
  • use shizuku for imitating key events
  • update documentation
    • add Shizuku setting
    • show Shizuku alongside installing the Key Mapper keyboard for key event actions
      - [ ] add to "apps using Shizuku" list. https://shizuku.rikka.app/apps/ will do once it is released to production
  • squash and merge
  • delete branch
@sds100 sds100 added the enhancement New feature or request label Jul 16, 2021
@sds100 sds100 self-assigned this Jul 16, 2021
@sds100 sds100 mentioned this issue Jul 16, 2021
Closed
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku): create settings page
e0a9d09
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat: add shizuku page to website
1e51f80
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat: recommend installing Shizuku for actions
00fb1d4
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku): update shizuku support url link
dacfbb3
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku): update shizuku support url link to go straight t…
7a6bc96 
…o the benefits
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku) grant WRITE_SECURE_SETTINGS with Shizuku
d759e75
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku) tweak how WRITE_SECURE_SETTINGS is granted
e961a23
sds100 added a commit that referenced this issue Jul 20, 2021
@sds100
#746 feat (shizuku) block when granting WRITE_SECURE_SETTINGS with root
e76c068
sds100 added a commit that referenced this issue Jul 22, 2021
@sds100
#746 feat: shizuku support
a7aafe0
@sds100
Copy link
Collaborator Author

sds100 commented Jul 22, 2021

implemented

@sds100 sds100 closed this as completed Jul 22, 2021
@sds100
Copy link
Collaborator Author

sds100 commented Jul 27, 2021 •
edited
Loading

  • automatically ask for Shizuku permission if it is installed and started when the app is opened
  • automatically grant WRITE_SECURE_SETTINGS permission if rooted or shizuku permission is enabled. show toast when doing this. "Key Mapper has granted itself permission with...".
  • use shizuku for open menu action

@sds100 sds100 reopened this Jul 27, 2021
sds100 added a commit that referenced this issue Sep 12, 2021
@sds100
#746 feat: automatically ask for Shizuku permission if it is installe…
58dae0d 
…d and started when the app is opened
sds100 added a commit that referenced this issue Sep 12, 2021
@sds100
#746 feat: automatically grant WRITE_SECURE_SETTINGS permission with …
2412731 
…Shizuku
@sds100
Copy link
Collaborator Author

sds100 commented Sep 12, 2021

implemented extra stuff

@sds100 sds100 closed this as completed Sep 12, 2021
sds100 added a commit that referenced this issue Sep 12, 2021
@sds100
#746 feat: use Shizuku for open menu action
8505c54
sds100 added a commit that referenced this issue Nov 7, 2021
@sds100
#746 feat: use Shizuku to imitate button presses
6403da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sds100 sds100

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sds100