-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidyup examples and internal InitialisedList
type
#8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
changed the title
Examples and InitialisedList tidyup
Tidyup examples and internal `InitialisedList type
Mar 29, 2023
dcousens
changed the title
Tidyup examples and internal `InitialisedList type
Tidyup examples and internal Mar 29, 2023
InitialisedList
type
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5649e01:
|
borisno2
reviewed
Mar 30, 2023
borisno2
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes a number of
CHANGELOG
s from the examples that are unused.These files are routinely copied between examples and are not useful for consumers, or us.
I have opted to remove them.
This pull request additionally changes the internal
InitialisedList
type to follow suite with a more consistent structure centered around the property keys we are used to. This should help future work currently ongoing in this area.This pull request has no changeset, as nothing has changed in respect to our publicly documented interfaces.
Users of
context.experimental.lists
will be impacted, but that outcome is part of usingexperimental
and will be trivially caught by Typescript.