Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyup examples and internal InitialisedList type #8438

Merged
merged 26 commits into from
Mar 30, 2023
Merged

Tidyup examples and internal InitialisedList type #8438

merged 26 commits into from
Mar 30, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Mar 29, 2023

This pull request removes a number of CHANGELOGs from the examples that are unused.
These files are routinely copied between examples and are not useful for consumers, or us.
I have opted to remove them.

This pull request additionally changes the internal InitialisedList type to follow suite with a more consistent structure centered around the property keys we are used to. This should help future work currently ongoing in this area.

This pull request has no changeset, as nothing has changed in respect to our publicly documented interfaces.
Users of context.experimental.lists will be impacted, but that outcome is part of using experimental and will be trivially caught by Typescript.

@dcousens dcousens requested a review from borisno2 March 29, 2023 06:19
@changeset-bot

This comment was marked as resolved.

@dcousens dcousens changed the title Examples and InitialisedList tidyup Tidyup examples and internal `InitialisedList type Mar 29, 2023
@dcousens dcousens changed the title Tidyup examples and internal `InitialisedList type Tidyup examples and internal InitialisedList type Mar 29, 2023
@dcousens dcousens self-assigned this Mar 29, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5649e01:

Sandbox Source
@keystone-6/sandbox Configuration

Copy link
Member

@borisno2 borisno2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants