Skip to content

Commit

Permalink
src,test: enable per_context.js shim
Browse files Browse the repository at this point in the history
This reverts commit f5d29d5.

PR-URL: nodejs#600
Refs: nodejs#565
Refs: nodejs#567
Reviewed-By: Jimmy Thomson <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Jack Horton <[email protected]>
  • Loading branch information
kfarnung committed Sep 20, 2018
1 parent f159167 commit e198aca
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2986,7 +2986,6 @@ Local<Context> NewContext(Isolate* isolate,
context->SetEmbedderData(
ContextEmbedderIndex::kAllowWasmCodeGeneration, True(isolate));

#ifndef NODE_ENGINE_CHAKRACORE
{
// Run lib/internal/per_context.js
Context::Scope context_scope(context);
Expand All @@ -2997,7 +2996,6 @@ Local<Context> NewContext(Isolate* isolate,
&per_context_src).ToLocalChecked();
s->Run(context).ToLocalChecked();
}
#endif

return context;
}
Expand Down
4 changes: 0 additions & 4 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,6 @@ test-vm-createcacheddata : SKIP
# Issue: https://github.com/nodejs/node-chakracore/issues/563
test-zlib-unused-weak : SKIP

# Removed the wake->notify shim code
# Issue: https://github.com/nodejs/node-chakracore/issues/565
test-atomics-notify : SKIP

# These tests rely on V8's custom heap dumping and validation
test-heapdump-dns : SKIP
test-heapdump-fs-promise : SKIP
Expand Down

0 comments on commit e198aca

Please sign in to comment.