Test hard coding category in VS #10325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
arianaw66
removed
the
keep pr updated
|
Closing in favor of solo-io#5006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add category to Gloo Gateway enterprise CRDs so that the convenient
kubectl get solo-iocan be used to see all GG enterprise CRs on the cluster.API changes
Added category to enterprise CRDs
Interesting decisions
This PR follows the example of solo-io#5592, which shows that solo-kit only generates the schema section of the CRD (see solo-io#5592 (comment)). Therefore, we hardcode the new category in the CRD yaml files.
Testing steps
Notes for reviewers
Checklist: