Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10366

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update README.md #10366

merged 3 commits into from
Nov 21, 2024

Conversation

linsun
Copy link
Contributor

@linsun linsun commented Nov 20, 2024

Update the warning msg, see PR for details

Update the warning msg.
@linsun linsun requested a review from yuval-k November 20, 2024 21:00
@linsun linsun requested a review from ilrudie November 20, 2024 21:36
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I do have a suggestion.

Co-authored-by: Ian Rudie <[email protected]>
@yuval-k yuval-k merged commit ee4fc25 into main Nov 21, 2024
10 checks passed
@yuval-k yuval-k deleted the linsun-patch-1 branch November 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants