New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumenting Ginkgo tests with JUnit and junit2oltp #10398

Closed

ryanrolds wants to merge 6 commits into kgateway-dev:main from solo-io:rolds/instrument_ginkgo_test

Contributor

ryanrolds commented Dec 10, 2024

Description

API changes

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works

ryanrolds added 6 commits

December 10, 2024 13:44


          Trying to run the junit2otel tool in CI

ea8d3cc


          Adjusting the block

b66317b


          Adjusting how we get the directory path

bc41f98


          Trying different line break style

d7cc9ca


          Merge branch 'main' into rolds/instrument_ginkgo_test

a61972f


          Trying different line break style

367aad4

Contributor

jenshu commented Jan 13, 2025

@ryanrolds are you still working on this or can it be closed?

ryanrolds closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet